Skip to content

"select" in variable name confuses parser #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kc9jud opened this issue Sep 24, 2019 · 5 comments · Fixed by #167
Closed

"select" in variable name confuses parser #149

kc9jud opened this issue Sep 24, 2019 · 5 comments · Fixed by #167
Labels
status:fixed-waiting-merge syntax-highlight

Comments

@kc9jud
Copy link

kc9jud commented Sep 24, 2019

Opening a file which contains a variable with select in the name appears to crash/confuse the parser:

image

with variable commented out:
image
@zurdala
Copy link

zurdala commented Sep 27, 2019

Same thing happens to me. Came here to report the same issue

@pedro-ricardo
Copy link
Collaborator

That's my bad 👎 ... I made a change when trying to generalize the select case and select type keywords that can be the cause of it ... I'll try to solve it soon.
Thank you for your feedback

@kc9jud
Copy link
Author

kc9jud commented Dec 4, 2019

@pedro-ricardo Any updates?

@pedro-ricardo
Copy link
Collaborator

I'm sorry @kc9jud , but my job is currently consuming all the time I've got. So I still haven't look into this, and to be honest it's way down on my priorities.

@kc9jud
Copy link
Author

kc9jud commented Dec 4, 2019

No worries -- I was considering trying to come up with a PR, but I wanted to make sure you weren't already working on it.

@kc9jud kc9jud mentioned this issue Feb 19, 2020
Closed
This was referenced Feb 24, 2020
Closed
Merged
@pedro-ricardo pedro-ricardo mentioned this issue Feb 27, 2020
Merged
13 tasks
pedro-ricardo added a commit that referenced this issue May 15, 2020
@pedro-ricardo
Minor release - version 2.2.0
db74870 
### Check List
- Highlight
- [x] `select` keyword - *Merge #165 to fix #149*
- [x] `rank` keyword -  *Merge #165*
- [x] `forall` keyword - *Merge #170 to fix #169*
- Symbol List
- [x] Symbols bug in VSCode +1.40 - *Merge #161 to fix #154*
- [x] Symbols classification - *Merge #141 to fix #140*
- [x] Long named symbols - *Merge #151*
- Settings
- [x] Add more options - *Merge #152*
- Dependencies
- [x] Merge `dependabot` PR's
    - [x] lodash - *Merge #144*
    - [x] mixin-deep - *Merge #146*
    - [x] handlebars - *Merge #155* 
- Code Completion
- [x] Array constructor - *Fix #148*
- New Features
- [x] Breakpoints - *Merge #150*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-waiting-merge syntax-highlight
Projects
None yet
Milestone
No milestone
3 participants
@kc9jud @pedro-ricardo @zurdala