Skip to content

Syntax highlighting fails at inline forall statements #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisspyB opened this issue Apr 8, 2020 · 1 comment · Fixed by #167
Closed

Syntax highlighting fails at inline forall statements #169

ChrisspyB opened this issue Apr 8, 2020 · 1 comment · Fixed by #167

Comments

@ChrisspyB
Copy link
Contributor

Hi all - nice extension, thanks for your work in maintaining this repo.

The syntax highlighting appears to be incorrect for forall statements that consist of only one line. Please see the following example:

Screenshot 2020-04-08 at 17 26 27

In line 4, arr(i) = i * i has been highlighted in red, even though this is valid syntax and the file compiles (gfortran). The error propagates to other parts of the program too: notice that the end statement is also no longer highlighted here. For comparison, compare with the highlighting when the forall removed.

Screenshot 2020-04-08 at 17 26 37

In more complex files, this error propagation becomes quite severe, causing a large number of syntax-highlighting issues, rendering some files almost unreadable.

Many thanks.

@pedro-ricardo
Copy link
Collaborator

Thank you for the report and Fix :+1
This will be released in #167.

pedro-ricardo added a commit that referenced this issue May 15, 2020
### Check List
- Highlight
- [x] `select` keyword - *Merge #165 to fix #149*
- [x] `rank` keyword -  *Merge #165*
- [x] `forall` keyword - *Merge #170 to fix #169*
- Symbol List
- [x] Symbols bug in VSCode +1.40 - *Merge #161 to fix #154*
- [x] Symbols classification - *Merge #141 to fix #140*
- [x] Long named symbols - *Merge #151*
- Settings
- [x] Add more options - *Merge #152*
- Dependencies
- [x] Merge `dependabot` PR's
    - [x] lodash - *Merge #144*
    - [x] mixin-deep - *Merge #146*
    - [x] handlebars - *Merge #155* 
- Code Completion
- [x] Array constructor - *Fix #148*
- New Features
- [x] Breakpoints - *Merge #150*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants