Skip to content

Log channel suppressed when activation fails #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnikit opened this issue Nov 14, 2021 · 1 comment
Closed

Log channel suppressed when activation fails #286

gnikit opened this issue Nov 14, 2021 · 1 comment
Assignees
Labels

Comments

@gnikit
Copy link
Member

gnikit commented Nov 14, 2021

Describe the bug
The log channel will not initialise when activation of the extension fails. This is relatively easy to happen since during activation we run the linter to all open fortran files. So if anything causes the linter to abort then the extension activation is not completed and the log channel is not initialised.

The solution is to make the logger global and not initialise it in the activate function

Build info (please complete the following information):

  • OS: All
  • Extension Version: ^2.3.0
  • Visual Studio Code Version: All
@gnikit gnikit added the bug label Nov 14, 2021
@gnikit gnikit self-assigned this Nov 14, 2021
@gnikit
Copy link
Member Author

gnikit commented Nov 24, 2021

This was fixed via ec07a9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant