Skip to content

bug(lint): adds fix for old GFortra 4.x.x #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2023
Merged

bug(lint): adds fix for old GFortra 4.x.x #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bcfa6c
bug(linter): adds support for old GFortran
gnikit Feb 5, 2023
c1b4dbe
docs: updated CHANGELOG
gnikit Feb 5, 2023
3d20cf1
chore: updated vscode settings for Meson
gnikit Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,6 @@
// Other Fortran options
"fortran.preferredCase": "lowercase",
// Supress Git pop-up interfering with UI testing
"git.openRepositoryInParentFolders": "always"
"git.openRepositoryInParentFolders": "always",
"mesonbuild.configureOnOpen": false
}
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

- Fixed linter REGEX for GFortran 4.x.x
([#813](https://github.com/fortran-lang/vscode-fortran-support/issues/813))
- Fixed GFortran version regex to allow for semver + build metadata
([#813](https://github.com/fortran-lang/vscode-fortran-support/issues/813))
- Fixed broken badges and replaced them with shields.io
([[#815](https://github.com/fortran-lang/vscode-fortran-support/issues/815)])
([#815](https://github.com/fortran-lang/vscode-fortran-support/issues/815))
- Fixed regular expression for parsing version of GFortran in linter
([#759](https://github.com/fortran-lang/vscode-fortran-support/issues/759))
- Fixed bug where diagnostic messages would linger from the previous state
Expand Down
2 changes: 1 addition & 1 deletion src/lib/linters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class GNULinter extends Linter {
constructor() {
super(
'gfortran',
/(?:^(?<fname>(?:\w:\\)?.*):(?<ln>\d+):(?<cn>\d+):(?:\s+.*\s+.*?\s+)(?<sev1>Error|Warning|Fatal Error):\s(?<msg1>.*)$)|(?:^(?<bin>\w+):\s*(?<sev2>\w+\s*\w*):\s*(?<msg2>.*)$)/gm,
/(?:^(?<fname>(?:\w:\\)?.*):(?<ln>\d+):(?<cn>\d+)[:.](?:\s+.*\s+.*?\s+)(?<sev1>Error|Warning|Fatal Error):\s(?<msg1>.*)$)|(?:^(?<bin>\w+):\s*(?<sev2>\w+\s*\w*):\s*(?<msg2>.*)$)/gm,
{
errors: ['error', 'fatal error'],
warnings: ['warning'],
Expand Down