Skip to content

Fix bing Temporary Patch (gh-pages) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

henilp105
Copy link
Member

This PR is to resolve #222 , Please refer : https://fortran-lang.discourse.group/t/4942

This is a temporary patch to fix the bing directly via gh-pages as it seems the most likely cause could be HTML redirection , as we don't have the functionality to add 301 Redirect in gh-pages, thus this PR is a temporary fix to this redirection bug , and this same method of redirection is also used in the fpm-docs repository and we seem to reproduce the same problem for the fpm-docs repository as well.

Thanks and Regards,
Henil

CC @awvwgk @certik

@henilp105 henilp105 requested a review from awvwgk May 21, 2023 05:47
@awvwgk
Copy link
Member

awvwgk commented May 21, 2023

Henil @henilp105, would it be possible to move the English language tree to fortran-lang.org and maybe have a duplicated one at fortran-lang.org/en? This way we don't need the additional redirect logic. Only thing to be careful about is that the language navigation works from both trees.

@henilp105
Copy link
Member Author

@awvwgk , we can move the English language tree (language redirects can be handled in sphinx templates for languages) but the redirects of older webpage (jekyll) will conflict with the English language tree ( can we disable the older redirects for jekyll build ? ).

@awvwgk
Copy link
Member

awvwgk commented May 21, 2023

We can remove all redirects which are not needed anymore once the English tree is in the page door.

@certik
Copy link
Member

certik commented May 21, 2023

I would remove all redirects and have the english page copied at fortran-lang.org/. It looks better anyway. This can be done with a script that runs after sphinx is finished.

@henilp105
Copy link
Member Author

Thanks @awvwgk @certik , can you Please Review #283 .

@henilp105 henilp105 closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants