Add pillow-simd as requirement if it is installed #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me! Thanks @0phoff for the fix and the detailed PR explanation. |
There was a problem hiding this comment.
@JackUrb is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #367, this PR allows visdom to work with Pillow-simd if the end user has it installed.
What this PR does, is that upon installation it checks if pillow-simd is installed and adds it to the requirements if it is. Otherwise, regular pillow is added.
Pillow-simd is a drop-in replacement that uses the same namespace, so no further changes are required.
Disclaimer:
I did not figure this one out on my own, but saw this solution in pytorch/vision.
This solution might have some problems I am not aware of, as I am no guru when working with setuptools. One thing I do know, is that this will cause a problem when creating pip wheels, so that should be taken into consideration. (I dont think that this is a concern for this project)