feat: support getAccount mode #48
Open
+73
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 21, 2025
mattsse
requested changes
Jun 4, 2025
mattsse
requested changes
Jun 10, 2025
| } | ||
| Err(_) => { | ||
| mode.store(ACCOUNT_FETCH_SEPARATE_REQUESTS, Ordering::Relaxed); | ||
| tokio::try_join!(balance_fut, nonce_fut, code_fut).map_err(Into::into) |
There was a problem hiding this comment.
this is a bit wasteful, because now, we're cancelling the already in progress other arm, what we could do here is drive the already in progress triple future to completion instead, if we first store it in a temp var instead of assigning it in the select macro like we do rn in L322
| provider.get_transaction_count(address).block_id(block_id).into_future(); | ||
| let code_fut = provider.get_code_at(address).block_id(block_id).into_future(); | ||
|
|
||
| tokio::select! { |
There was a problem hiding this comment.
the select is good here, becuase if this does support ethgetinfo, then this is the most efficient impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47