Forge coverage: incomplete report

[Amxx]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

1.3.5-nightly

What version of Foundryup are you on?

No response

What command(s) is the bug in?

forge coverage --report lcov --ir-minimum

Operating System

Linux

Describe the bug

Our CI runs solidity-coverage and foundry coverage. Both outputs are passed to app.codecov.io.

I've noticed that tests that are only covered by foundry are not reported properly. Lines that are obviously covered are not reported as such. This ends up giving low coverage numbers that block merging our PRs.

See example of code bellow:

• return and assembly ("memory-safe") { lines are marked as not-covered.

[grandizzy]

@Amxx thank you, we just ported to solar in nightly builds, mind to clarify if you see same issue with stable version too? steps to repro would be great, thank you!

[Amxx]

I noticed the issue forking on this PR.

I tried running locally with 1.3.5-v1.3.5. I don't have the UI setup so its hard to say anything changes, but the lcov.info looks similar.

Note that the CI (which produced the screenshare above) uses stable

[grandizzy]

thank you, was able to repro! the issue here is that --ir-minimum is used which results in losing accuracy. We track improving it in #3357