fix(anvil): recomputing next-base-fee after reloading state #10488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naps62
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
mattsse
approved these changes
May 9, 2025
mattsse
previously requested changes
May 9, 2025
There was a problem hiding this comment.
could we perhaps also add an additional tests like this one here
foundry/crates/anvil/tests/it/state.rs
Line 13 in 19ecdde
|
test added |
yash-atreya
approved these changes
May 12, 2025
grandizzy
changed the title
mattsse
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10484
probably not the cleanest solution, but at least seems I have found the root cause. would appreciate some guidance in how to clean this up, or potential edge cases I may have missed