feat: cast storage --solc-version CLI argument

[zugdev]

Motivation

#9939 is a feature request for --solc-version as a CLI argument for cast storage. This is my first PR, please be as strict as possible so I can learn.

Solution

User can override the detected version by passing cast storage --solc-version <version>, I've added a conditional in case the argument is passed.

I have a few observations:

1. It's not clear by spec, whether it should be a global cast argument
2. Should I forbid the user from passing a version older than MIN_SOLC or an invalid compiler version for that artifact? The warning and error message are already displayed in each case.
3. Should I add a test set?

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[zugdev]

bumping for feedback!

[grandizzy]

thank you!

It's not clear by spec, whether it should be a global cast argument

IMO storage related should be fine, we can extend if needed on other commands

Should I forbid the user from passing a version older than MIN_SOLC or an invalid compiler version for that artifact?

The warning and error message are already displayed in each case.
Nope, don't think we should

@zerosnacks wdyt on points above?

Should I add a test set?

Yes, please add a test for this, there are samples in cast.rs

[zugdev]

IMO storage related should be fine, we can extend if needed on other commands

This makes sense.

The warning and error message are already displayed in each case. Nope, don't think we should

I agree.

Yes, please add a test for this, there are samples in cast.rs

I didn't find a file named cast.rs but I checked others for context (e.g. cast/cmd/call.rs and tests/cli/main.rs).

My test set includes tests

1. to ensure solc version is correctly unwrapped;
2. to assert success if a valid version is provided;
3. to assert failure, and the appropriate error message, if the provided version isn't valid.

Please, feel free to tag me with requests and feedback.

[zugdev]

Bumping! i don't mean to be annoying, I just want to work on other issues and I can make better PRs after this first review.