Incognito & Container Support

[erosman]

Incognito & Container Support

Support can be added for Firefox only.
See also: #27

User Interface

Incognito can be supported without any issues. However to support containers as well. there are 2 options for the User Interface:

1. Generic User Interface

Use a generic container list, not knowing or matching the number of containers the user has e.g.

• Incognito
• Container 1
• Container 2
• Container 3
• Container 4

2. Specific User Interface

Get the container list contextualIdentities.query() and create the UI

• contextualIdentities

  To use this API you need to include the "contextualIdentities" and "cookies" permissions in your manifest.json file.

• Adding "contextualIdentities" permission automatically enables containers in Firefox which is undesirable to users who don't want to use containers
• "contextualIdentities" permission is not available as an optional_permissions
• See also: Bug 1386673: Make Contextual Identity extensions be an optional permission

Implementation

• Incognito/Containers can be set to a specific proxy (not patterns or PAC URL)
• Incognito/Container settings will have precedence over other settings (except Tab Proxy)

The checking order would be:

1. Tab Proxy
2. Incognito/Container Proxy
3. Check for "Disable" mode
4. Global Exclude
5. PAC URL
6. Proxy by Patterns or Individual Proxy

To decide

• Should "Disable" disable everything?
• Should Tab Proxy be independent of "Disable" since it has its own independent on/off?
• Should Incognito/Container Proxy be independent of "Disable"?

Sync and Preferences: Import/Export

Container settings may mismatch, if the user has different containers on different browsers.

[erosman]

FoxyProxy v8.1 includes incognito & container support for Firefox only.
The Log is also updated to include incognito & container details.

The feature is still under consideration and development.

[pmarks-net]

The Incognito feature doesn't seem to do anything on Firefox 118. Here's what I tried:

• Copy manifest-firefox.json to manifest.json
• Load manifest.json from about:debugging
• Run in Private Windows > Allow
• Proxies > add 10.2.2.1, SOCKS5, 1080
• Options > Incognito > 10.2.2.1:1080
  
• Open a private window
• https://ifconfig.me/ still shows non-proxied IP address
• Click FoxyProxy icon > 10.2.2.1:1080
• https://ifconfig.me/ shows proxied IP address (but this affects regular tabs too)

[erosman]

I have uploaded the under-development v8.1 for another issue (#35). Therefore, the incognito & container is not finalised yet.

Update
Found the issue and updated the repo

[TriMoon]

wrt. "Tab Proxy":

It would be nice to have an option "DIRECT" (or "Disabled") in the drop-down list to select as proxy to use for the tab, which would temporarily disable all proxies for the tab 😉

• A workaround could be to create such a proxy manually and select it, but it's nicer to have that functionality in your UI by default 😸
• Even when you select a tab proxy in the drop-down list and click and "Set Tab Proxy" it is not shown when you re-open the popup or reload the page, which might be a good idea also. 👍

[erosman]

It would be nice to have an option "DIRECT" (or "Disabled") in the drop-down list to select as proxy to use for the tab, which would temporarily disable all proxies for the tab
There are set & unset to enable and disable Tab proxy.

I can look into adding a DIRECT option to Set Tab Proxy which would disable all proxying related to that tab.

Even when you select a tab proxy in the drop-down list and click and "Set Tab Proxy" it is not shown when you re-open the popup or reload the page, which might be a good idea also.

Set Tab Proxy is an independent function and its data is not saved. The page-action icon is set to show if a tab has Tab Proxy or not. It is possible to grab the data but that would involve a number of async processes which have to be performed every time the popup is shown but not applicable 99% of the times.

[pmarks-net]

It is possible to grab the data but that would involve a number of async processes which have to be performed every time the popup is shown but not applicable 99% of the times.

As the developer, you're free to do whatever you want, but if your code isn't doing the hard work to keep track of its own state, then what hope do the users have of understanding what's happening? I notice that the pageAction icon disappears when I reload the page, for example.

[erosman]

As the developer, you're free to do whatever you want, but if your code isn't doing the hard work to keep track of its own state, then what hope do the users have of understanding what's happening?

If there is popular demand for a feature, it will be looked into.

I notice that the pageAction icon disappears when I reload the page, for example.

That shouldn't happen. I will look into it.

[pmarks-net]

If there is popular demand for a feature, it will be looked into.

I'm talking more about a design philosophy. When adding a feature, often the hardest part is making it comprehensible to the user: https://en.wikipedia.org/wiki/The_Design_of_Everyday_Things

[erosman]

The performance also matters.

Add-on Policies: Development Practices
Add-ons must not negatively impact the performance or stability of Firefox.