Overall architecture RFC #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
reviewed
Aug 31, 2021
iduartgomez
reviewed
Aug 31, 2021
iduartgomez
reviewed
Sep 8, 2021
|
Great suggestions, I'll add to the doc.
…On Wed, Sep 8, 2021 at 2:00 PM Nacho Duart ***@***.***' via 33Mail ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/components.md
<#1 (comment)>:
> ## Key-Value store
+A persistent local store of keys and values in which keys are cryptographic contracts
+specified in [WebAssembly](https://en.wikipedia.org/wiki/WebAssembly). These contracts
+specify whether some data is valid, for example by checking a digital signature, a
+generalization of the concept of [content addressable storage](https://en.wikipedia.org/wiki/Content-addressable_storage),
+as [pioneered](https://github.com/freenet/wiki/wiki/Signed-Subspace-Key) by FreenetV1.
+
+The key/value pairs are stored locally in a lightweight database.
For local storage we may want to look for some embedded k/v db, some
alternatives:
- RocksDB
- LMDB
Pure Rust projects:
- Sled <https://github.com/spacejam/sled>
- Percy <https://persy.rs/>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFUI4K4WZQYHRSKZNJGW3UA6XDNANCNFSM5DCDWGRA>
.
This email was sent to the alias ***@***.***' by '
***@***.***',
and 33Mail forwarded it to you. To block all further emails to this alias
click here
<http://www.33mail.com/alias/unsub/eb1d1eb814fd59bd676e244f11659808>
* Own your own domain?* You can use it with a 33mail Premium Account.
Upgrade here
<https://www.33mail.com/ad/click/c5e1d67b2946df924d53c3fb0332bd4df9a25111/2/14/https%3A%2F%2Fwww.33mail.com%2Fchoose-account>
(Prefer no ads? Upgrade to Premium.
<https://www.33mail.com/ad/click/c5e1d67b2946df924d53c3fb0332bd4df9a25111/2/4/http%3A%2F%2Fwww.33mail.com%2Fdashboard%2Fchoose_account>
)
--
Ian Clarke
http://blog.locut.us/
|
sanity
added a commit
that referenced
this pull request
Sep 24, 2025
## Phase 1-2 Fixes Applied: ### Issue #1: Transaction ID correlation in client_events - Fixed missing WaitingTransaction::Subscription registration - Now properly routes subscription responses back to clients - Without this fix, clients would never receive SubscribeResponse messages ### Issue #2: Short-circuit on first peer failure in subscribe.rs - Replaced closest_potentially_caching with k_closest_potentially_caching - Now tries up to 3 candidate peers instead of failing on first unavailable peer - Fixes subscription failures for nodes at optimal location - Applied to all 3 occurrences in subscribe.rs operations ## What these fixes address: - Nodes at optimal location can now successfully subscribe to contracts - Multiple peer candidates prevent single point of failure in routing - Proper transaction correlation ensures client responses are delivered - Eliminates "no remote peers available" failures in connected networks ## Files Modified: - crates/core/src/client_events/mod.rs: Transaction correlation fix - crates/core/src/operations/subscribe.rs: Multi-candidate peer selection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall architecture RFC