Skip to content

Conversation

dinuchiriac
Copy link
Contributor

The env should be a property of an options Object and should not be passed directly. By sending it directly it will clash with other libraries that are trying to override exec Options. In my case, this is pkg library, see: https://github.com/zeit/pkg/blob/master/prelude/bootstrap.js#L1336
See child_process.exec docs: https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

@friedrith
Copy link
Owner

Thx for the PR, I resolve conflicts and I merge it after.

@friedrith friedrith merged commit 66b5494 into friedrith:dev Dec 24, 2018
@dinuchiriac dinuchiriac deleted the fixExecOptions branch December 24, 2018 10:40
@lock
Copy link

lock bot commented Mar 18, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants