fix child_process.exec options format #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
env
should be a property of an options Object and should not be passed directly. By sending it directly it will clash with other libraries that are trying to overrideexec
Options
. In my case, this ispkg
library, see: https://github.com/zeit/pkg/blob/master/prelude/bootstrap.js#L1336See
child_process.exec
docs: https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback