Update android.js #102
Open
Update android.js #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is now part of |
brody4hire
pushed a commit
to brody4hire/create-react-native-module
that referenced
this pull request
Apr 9, 2019
Merge commit 'refs/pull/102/head' of https://github.com/frostney/react-native-create-library into dev Updates the Android Gradle version to 3.3.2 in generated android/build.gradle to match https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle as proposed in frostney/react-native-create-library#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:
The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).
for more info, you can refer to this thread and especially this comment.