JSON and JSDoc updates #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just makes it so that doing `npx eslint .` it will include json files in the linting since it is in the overrides. https://eslint.org/docs/latest/use/command-line-interface#--ext "Default Value: .js and the files that match the overrides entries of your configuration."
joeycozza
approved these changes
Mar 8, 2023
|
I didn't know about using the overrides for other extensions to automatically get them. That is nice. Thanks. |
FSVetaz
added a commit
to fs-webdev/eslint-config-tree
that referenced
this pull request
Mar 8, 2023
4 tasks
FSVetaz
added a commit
to fs-webdev/eslint-config-tree
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one in the org uses JSDocs' rules from here currently. Tree Web team uses the config in their additional config so it would be good to just have the jsdoc rules in one place and tree team extend frontier's JSdocs' rules.
Put json config in an override for .json files mainly because then json files are linted by default (npx eslint .) instead of explicitly linting for that extension (npx eslint . --ext .json) See https://eslint.org/docs/latest/use/command-line-interface#--ext