Skip to content

npm update and cut the release like @fs/eslint-config-frontier-react #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2023
Merged

npm update and cut the release like @fs/eslint-config-frontier-react #18

merged 2 commits into from
Dec 13, 2023

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Dec 13, 2023

Updated because I saw that @fs/eslint-config-frontier-react had cut the release.

my only concern is the new JSDoc description does not satisfy the regex. @skye2k2 Could you take a look at that?

@FSVetaz
npm update and cut the release like @fs/eslint-config-frontier-react
fef08e6 
my only concern is the new JSDoc description does not satisfy the regex.
@FSVetaz FSVetaz requested a review from skye2k2 December 13, 2023 16:22
@FSVetaz FSVetaz requested a review from a team as a code owner December 13, 2023 16:22
@skye2k2
Tweaks
fb4b781 
Update eslint-plugin-sonarjs.
Update rule definitions to better match what we have in zion.
Update demo file to extend case statements enough to trigger in the new world.
Update snapshots.
@skye2k2
Copy link
Collaborator

skye2k2 commented Dec 13, 2023

@FSVetaz: It appears that it is recommended to not call out @description sections in JSDocs, so we have one additional warning. Verified that removing it drops the warning. Should be good to add.

@FSVetaz FSVetaz merged commit 9cccc2e into master Dec 13, 2023
@FSVetaz FSVetaz deleted the jordi/update branch December 13, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skye2k2 skye2k2 skye2k2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FSVetaz @skye2k2