Skip to content

Integrate dotnet/fsharp from 48f932cf8 to 085985140 #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 163 commits into from
Nov 9, 2019

Conversation

baronfel
Copy link
Collaborator

@baronfel baronfel commented Nov 9, 2019

Integrate dotnet/fsharp from 48f932c to 0859851. Notable changes include:

  • allowing '_' as a self-identifier
  • events for FSI evaluation lifecycle events
  • enhancements to FSI return-values
  • fixed parsing for langversion CLI arguments
  • allow cancellation of FSI interactions
  • ToString fixes for value options
  • Fixes for code generation in autogenerated members for very large records
  • make ranges of member declarations capture the entire member
  • improve error recovery in the parser
  • improve logic for auto-detecting 'framework' assemblies for FSI

dotnet-maestro bot and others added 30 commits August 1, 2019 17:15
…731.19 (#7320)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19381.19
* debug formatting

* whitespace

* whitespace

* Update DetupleArgs.fs
* Move WrongSyntaxInForLoop test

* fix test
* Moved CodeGen/EmittedIL/LiteralValue over to NUnit

* Expected IL simplified to test one thing and to be runtime independent
* Moved Suggestion Tests over to NUnit

* Try to activate suggestions in unit tests

* Fix suggestion tests

* Fix suggestion tests

* Fix suggestion tests

* Fix suggestion tests
…801.23 (#7342)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19401.23
…802.16 (#7351)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19402.16
* Update dependencies from https://github.com/dotnet/arcade build 20190803.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19403.1

* Update dependencies from https://github.com/dotnet/arcade build 20190804.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19404.1
…805.9 (#7360)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19405.9
* Fix test case race

* Tell test suite to use netcore2.1 and compilerassert to use the required framework version

* netcore3 the lot
…806.7 (#7364)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19406.7
…807.9 (#7368)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19407.9
* update build definition to use stages

* disable arcade NuGet package validation
* Use netcoresdk 3.0

* Use appdomain and load context

* temp

* Execute in appdomain, or assemblyloadcontext

* fscore

* linux

* Try to publish test logs from Linux/MacOS

* Copy paste error

* netcoreapp3

* feedback
…370)

Due to internal package publishing policies, the author of a package
published via a Microsoft account must be exactly 'Microsoft'.  To preserve
attribution to the F# Software Foundation, mention is made in the <description>
tag of FSharp.Core.
* Re-enable surface area tests in master branch

* net40 surface area
…808.13 (#7371)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19408.13
* raw code-gen Mutable tests copy-paste

* Allow  to use code snippets with warnings in tests

* Replace random/temp assembly name by `asmName` in generated IL

* map `System.Runtime` types to `mscorlib` for .NET Core tests

* allow to use IL from full framework and .net core as `expected IL`

* remove old tests

*  Different error messages for `not found` expected IL and not `not fully found` IL

* CompilerAssert.CompileLibraryAndVerifyILWithOptions and expected IL update

* Added `-g` option

* Reverted back unused variable
…809.8 (#7382)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19409.8
…810.2 (#7385)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19410.2
* Update dependencies from https://github.com/dotnet/arcade build 20190811.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19411.1

* Update dependencies from https://github.com/dotnet/arcade build 20190812.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19412.1
…812.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19412.7
…815.27

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19415.27
…816.16

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19416.16
KevinRansom and others added 27 commits November 9, 2019 09:56
* Ref assemblies for non sdk apps

* Use NumberStyles.AllowDecimalPoint with Parse

* Correctly this time

* Improved Assembly search
* Fix some issues in ValueNone implementation

* More debug display

* Some for options in debug display

* Apply suggestions from code review

Co-Authored-By: Eugene Auduchinok <[email protected]>

* Probably better stringing

* Add them baselines

* Add sprintfn tests

* Update OptionModule.fs
* Optimize Seq.Last like Seq.Length

Add type check to Seq.Last and Seq.TryLast to avoid full iteration if not necessary. Like Seq.Length does it at
https://github.com/dotnet/fsharp/blob/c18e1780b3f3f345364cb1ad8e510ea9f4590d3a/src/fsharp/FSharp.Core/seq.fs#L709

* Add test for Optimized Seq.Last and Seq.TryLast

* style update

* style update 2

* update comments and fix build error

Github Build error was:
 Check failure on line 132 in tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs

@azure-pipelines
azure-pipelines
/ fsharp-ci (Build Windows vs_release)

tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs#L132
tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs(132,58): error FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'a has been constrained to be type 'unit'.

* include List.last case

* include list in tests

* ensure same exception is raised on empty list

* typo

* Added implementation of List.last since it is not available at this point due to compilation error

The recursive function could also be defined inside but i guess then it would be reallocated on every call to Seq.Last (in case of list match).
An alternative would be to add .Last member on list type (like .Length member)

* inline List.last

reverting my previous attempt  dotnet/fsharp@b329e23
tail rec functions should be inlined

* typo in tests(build failed)

* typo2 in test (Build failed)

* move implemnetation to internal module

as suggested by dsyme

* renamed internal tryLast to tryLastV
* Fix member declaration ranges

* Fix member declaration ranges

* Update baseline

* Update baseline
…table (#7682)

* Recover ValNoMutable and PropertyCannotBeSet errors

* Recover FieldNotMutable error

* Refactor tests

* Refactor tests

* Update baseline
* init a basic readme.md for fsharp test suite

* fix title and try to add link

* case sensitive?

* Update layout.

* Update readme.md
* Update dependencies from https://github.com/dotnet/arcade build 20191004.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19504.2

* Update dependencies from https://github.com/dotnet/arcade build 20191005.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19505.1

* Update dependencies from https://github.com/dotnet/arcade build 20191006.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19506.1

* Update dependencies from https://github.com/dotnet/arcade build 20191009.5

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19509.5

* Update dependencies from https://github.com/dotnet/arcade build 20191010.4

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19510.4

* Update dependencies from https://github.com/dotnet/arcade build 20191011.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19511.1

* Update dependencies from https://github.com/dotnet/arcade build 20191015.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.1

* Update dependencies from https://github.com/dotnet/arcade build 20191015.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.2

* Update dependencies from https://github.com/dotnet/arcade build 20191017.8

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19517.8

* Update dependencies from https://github.com/dotnet/arcade build 20191018.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19518.2

* Update dependencies from https://github.com/dotnet/arcade build 20191021.4

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19521.4

* Update dependencies from https://github.com/dotnet/arcade build 20191022.8

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19522.8

* Update dependencies from https://github.com/dotnet/arcade build 20191023.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19523.3

* Update dependencies from https://github.com/dotnet/arcade build 20191024.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19524.2

* Update dependencies from https://github.com/dotnet/arcade build 20191025.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2

* Update dependencies from https://github.com/dotnet/arcade build 20191026.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19526.1

* Update dependencies from https://github.com/dotnet/arcade build 20191027.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19527.3

* Update dependencies from https://github.com/dotnet/arcade build 20191028.5

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19528.5

* Update dependencies from https://github.com/dotnet/arcade build 20191029.9

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19529.9

* Update dependencies from https://github.com/dotnet/arcade build 20191030.15

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19530.15

* Update dependencies from https://github.com/dotnet/arcade build 20191031.14

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19531.14

* Update dependencies from https://github.com/dotnet/arcade build 20191101.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19551.3

* Update dependencies from https://github.com/dotnet/arcade build 20191102.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19552.1

* Update dependencies from https://github.com/dotnet/arcade build 20191104.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19554.3

* work around dotnet/wpf#1718 by not embedding untracked sources

* use arcade mechanism of populating package icons
FreeVars cache optimization on Expr.Let
…105.7

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19555.7
…28f-7727ed23bc03

[master] Update dependencies from dotnet/arcade
…106.10

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19556.10
…107.20

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19557.20
ImplicitZero is also used in error recovery during parsing, and the current comment contradicts it.
…298-cd724a96316e

[master] Update dependencies from dotnet/arcade
@baronfel
Copy link
Collaborator Author

baronfel commented Nov 9, 2019

Mono failure is a random segfault (again). Merging.

@baronfel baronfel merged commit eac3185 into fsharp:master Nov 9, 2019
@baronfel baronfel deleted the integrate-october branch November 9, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.