-
Notifications
You must be signed in to change notification settings - Fork 61
Time individual puzzles #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I expected this issue after today 😆. I would accept a PR for this. A I think the complexity lies in updating the benchmark table when days or parts need to be spliced in etc. In the meantime, maybe adjusting the benchmark count for abnormally long cases could solve the immediate pain. It is defined here: advent-of-code-rust/src/template/runner.rs Lines 54 to 60 in 47e4f22
|
you can also check out the changes in #44 we just merged. this would allow you to skip running offending slow parts for a day temporarily. |
The benchmark table can be cached in a json file, so that it make it easier to update a specific day or part and then update the table in the README |
Sounds like a simple solution to meOn Dec 7, 2023 10:29, Tristan Guichaoua ***@***.***> wrote:
I think the complexity lies in updating the benchmark table when days or parts need to be spliced in etc.
The benchmark table can be cached in a json file, so that it make it easier to update a specific day or part and then update the table in the README
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Good idea! 💪 That sounds like a reasonable implementation. |
I will take a stab at this over the next couple of days, using the JSON file based approach mentioned above. This will involve creating a separate @MLNW @tguichaoua do you have any pref in regards to the default behavior of Should it: |
I prefer option A, it's more likely that the user wants to update the time for new solutions rather than recalculating everything. |
Thanks! And I agree about |
I agree, only run time for missing days and provide the option to run time for a specific day. Thanks for taking the time! |
I have a working implementation here. I settled on The only limitation I can think of right now is that it's not possible to re-time a single part, mainly because it would be a large refactor and I'm not sure it's all too relevant. I will add some much needed tests and clean it up, then open a PR. |
In the light of solutions that may take a long time to run it would be great to have the option to time only one puzzle.
I.e.: allow
cargo time 5
to only time day 5.I guess the hardest bit would be to include the result in the benchmark table. Though it should be manageable.
The text was updated successfully, but these errors were encountered: