Allow async cat_* in simplecache #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely beautiful. Thank you, this is a HUGE help to us!! |
|
@martindurant this PR seems to have broken something when writing files with |
ariostas
reviewed
Jul 16, 2025
| lpaths = [l for l, p in zip(lpaths, paths) if l is False] | ||
| self.fs.get(rpaths, lpaths) | ||
| return super().cat_ranges( | ||
| return LocalFileSystem().cat_ranges( |
There was a problem hiding this comment.
Why did this need to be changed? Switching this back fixes the issue
There was a problem hiding this comment.
The original was pulling the bytes from remote, which is exactly what the cache filesystem is supposed to prevent, and what this PR was for. Are the file(s) really not in the local store?
However, I can see that this code is wrong. Can you try adding the following line before the one highlighted:
paths = [self._check_file(p) for p in paths]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #1869