Skip to content

Change to offset, size #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Change to offset, size #5

merged 1 commit into from
Nov 19, 2020

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented Nov 18, 2020

As discussed in #4, the preference from the community seems to be for offset, size instead of start, stop for encoding item locations within a file.

@martindurant
Copy link
Member

Hoping to get many suggestions like this one, to arrive as a sensible concrete spec!

It would be handy to update the HDF crawler implementation as the spec changes (and later ReferenceFileSystem in fsspec) so that things don't get out of sync too much.

@rsignell-usgs
Copy link
Collaborator

rsignell-usgs commented Nov 19, 2020

Smaller representation and easier to socialize? Sounds good to me! Thanks @rabernat!
@martindurant, what do you think about merging this, then I'll see if I can solicit a few more reviews?

@martindurant
Copy link
Member

OK merging. Spec before implementation :)

@martindurant martindurant merged commit 5bcbf64 into fsspec:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants