Change to offset, size #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hoping to get many suggestions like this one, to arrive as a sensible concrete spec! It would be handy to update the HDF crawler implementation as the spec changes (and later ReferenceFileSystem in fsspec) so that things don't get out of sync too much. |
|
Smaller representation and easier to socialize? Sounds good to me! Thanks @rabernat! |
|
OK merging. Spec before implementation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4, the preference from the community seems to be for
offset, sizeinstead ofstart, stopfor encoding item locations within a file.