Accessor refactoring and CloudPath #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstriebel
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Nice, I like the simplifications! I was wondering if _FSSpecAccessor should even subclass fsspec.AbstractFileSystem directly, but since the methods needed are well known and only a few, I think the current version is more clear.
Please see my one comment below, besides this LGTM 👍
upath/implementations/hdfs.py
Outdated
| return wrapper | ||
| def touch(self, **kwargs): | ||
| kwargs.pop("trunicate", None) | ||
| self._accessor.touch(self, **kwargs) |
There was a problem hiding this comment.
I'm not sure if there is self._accessor here? Shouldn't this rather be
Suggested change
| self._accessor.touch(self, **kwargs) | |
| super().touch(self, **kwargs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
_FSSpecAccessorto work without__getattribute__magic. This makes it much easier to reason about the code while adding only a bit of boilerplate. In fact, it even decreases the lines of code.Addtionally, this PR merges the
S3PathandGCSPathclasses into aCloudPath(could also be calledCloudStoragePath, let me know what you prefer), because all their implementations were identical.