Skip to content

fix: incomplete/incorrect headers sent when establishing event hub connection #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2023
Merged

fix: incomplete/incorrect headers sent when establishing event hub connection #13

merged 5 commits into from
Mar 28, 2023

Conversation

octavian-ionescu
Copy link
Collaborator

@octavian-ionescu octavian-ionescu commented Mar 28, 2023 •
edited by torsdag
Loading

Resolves FT-6c5e6756-1253-4eac-985b-d759a4b5d71a

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains updates to the release notes.
  • I have verified that the documentation is still up to date.

Changes

Incomplete / malformed headers were being generated for websocket connections. This caused some ingress controllers to throw an error.

Upgrade: websocket
Host: k3s-terraform.ftrackapp.com
Origin: http://k3s-terraform.ftrackapp.com/
Sec-WebSocket-Key: qPLLoRR9cZjCDlc6Jz6L3w==
Sec-WebSocket-Version: 13
Connection: Upgrade
User-Agent
Accept-Encoding
Accept
Connection
ftrack-strict-api

Test

Ensure that the headers present in the websocket connection / handshake are complete

@octavian-ionescu octavian-ionescu requested a review from a team as a code owner March 28, 2023 13:11
@octavian-ionescu octavian-ionescu self-assigned this Mar 28, 2023
torsdag
torsdag approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@torsdag torsdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@torsdag torsdag merged commit ff83457 into main Mar 28, 2023
@torsdag torsdag deleted the backlog/Incorrect-headers-sent-when-establishing-event-hub-connection branch March 28, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torsdag torsdag torsdag approved these changes

@bjornrydahl bjornrydahl Awaiting requested review from bjornrydahl

Assignees

@octavian-ionescu octavian-ionescu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octavian-ionescu @torsdag