Skip to content

bad commit #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2022
Merged

bad commit #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c84e4
bad commit
fullstackzach Sep 20, 2022
0ed31d1
bad commit 2
fullstackzach Sep 20, 2022
525e9b2
AUS-1234
fullstackzach Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/commit-linting-loose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ fi

# If we made it this far, no JIRA ticket # was detected in a commit or branch, print the reject message and fail the job

echo "⛔️ At least one commit message OR your branch name must include a JIRA ticket number e.g. \"AUS-1234\". This can be anywhere in your commit"
echo "⛔️ At least one commit OR your branch name must include a JIRA ticket number e.g. \"AUS-1234\". This can be anywhere in your commit"
echo "You can skip this whole step if necessary by running \"git commit --amend\" and add \"[skip jira]\" in your last commit message, and force-push"
echo "Please fix the commit message and push again."
echo "https://help.github.com/en/articles/changing-a-commit-message"
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/commit-linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@ jobs:
ref: '${{ github.event.pull_request.base.ref }}'

- name: Branch or Commits includes a Jira issue
run: bash ${GITHUB_WORKSPACE}/.github/scripts/commit-linting-loose.sh ${{ github.event.pull_request.head.ref }} ${{ github.event.pull_request.base.ref }}
run: |
git checkout ${{ github.event.pull_request.head.ref }}
bash ${GITHUB_WORKSPACE}/.github/scripts/commit-linting-loose.sh ${{ github.event.pull_request.head.ref }} ${{ github.event.pull_request.base.ref }}