-
Notifications
You must be signed in to change notification settings - Fork 231
Kotlin DSL support #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Kotlin DSL support #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include Gradle API, Kotlin DSL jar and generated extensions.
Also omit the base classloader when loading the Kotlin script template classes at runtime.
Print dynamically generated Kotlin DSL accessors (e.g. the 'compile' configuration method) when resolving the classpath of Kotlin DSL projects. Also move the Kotlin DSL classpath resolution logic into a separate script.
Use a separate class path for build scripts at the compiler level.
Automatically update the classpath if a Gradle buildfile changes and query the build script classpath in CompilerClassPath.
Use the new Kotlin scripting API to register script templates.
Additionally, clean up the ScriptDefinition construction by getting rid of the legacy 'KotlinScriptDefinition' type.
Implicit imports now work, thus the PR is ready for merge. #76 should be fixed too. |
Verify that hovers and code completion work correctly in *.gradle.kts build files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
This PR will contain experimental support for Gradle's Kotlin DSL buildscripts (
build.gradle.kts
). Currently, the classpath is resolved correctly, the script, however, still shows error messages as the top-level context is not recognized as aKotlinBuildScript
:See here for details about the template classes.