URGENT: Fix startup issue for language server caused by lsp4j 0.15 upgrade #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @fwcd , seems like I was too quick to approve a recent PR:
#381
lsp4j 0.15 causes the following startup issue in many clients:
The issue has been fixed in a later commit in lsp4j (probably included in next version 0.16). I was able to do the same in our language server and fix the startup issues.
eclipse-lsp4j/lsp4j@04b0c61
Emacs gives a warning of a null value, but ignores it. VSCode works like a charm when I tested it just now.
Again, sorry for not noticing this before I approved the other PR 🙁