Fix issue where code action doesn't show up, unless entire text marked #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you don't mark the entire text. Happens in editors that are not VSCode
|
I think this happens in VSCode too, at least I vaguely recall having to select the entire diagnostic's range to get a quick fix, but it might also have been some other language server. In any case, thanks for looking into this! |
fwcd
reviewed
Aug 30, 2022
server/src/main/kotlin/org/javacs/kt/codeaction/quickfix/QuickFix.kt
Outdated
Show resolved
Hide resolved
|
|
||
| fun diagnosticMatch(diagnostic: KotlinDiagnostic, startCursor: Int, endCursor: Int, diagnosticTypes: Set<String>): Boolean = | ||
| diagnostic.textRanges.any { it.startOffset == startCursor && it.endOffset == endCursor } && diagnosticTypes.contains(diagnostic.factory.name) | ||
| diagnostic.textRanges.any { it.startOffset <= startCursor && it.endOffset >= endCursor } && diagnosticTypes.contains(diagnostic.factory.name) |
There was a problem hiding this comment.
Similarly here, it might be worth checking if there is a similar function for Kotlin's TextRange, this might be useful in other places too.
There was a problem hiding this comment.
I think I will look further into that in a future PR. Right now I don't see how it will improve the current code without some rewrites. I might be wrong though 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where implement abstract members code action doesn't show up if you don't mark the entire text. Happens in editors that are not VSCode. The editor I experience it in is Emacs, as discussed in #366. Might be other editors as well, as I've heard from some non-VSCode that they never see any code actions.