General override member(s) functionality - VSCode version #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very interesting, thanks for working on this! Hope to find some time to go through this in detail soon. If LSP were to get upstream support for the override/implement UI one day, it shouldn't be too hard to migrate either. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple VSCode usage of the override member protocol extension found in: fwcd/kotlin-language-server#379 (need to be merged after that PR).
Have some TODOs I couldn't resolve for now. I suggest we keep that for future work, as it is better to have something working than to use too much time on a "perfect solution". Currently this version does exactly the same as the Emacs version, that was shown in the kotlin-language-server PR, does. Have added a nifty right-click menu to override members that make it simple. No hotkey, but that is because I don't know what people would prefer. Feel free to suggest something 🙂 You can also run it with the command palette, using the command kotlin.overrideMember.
How the selection menu looks:
And clicking okay and seeing the overrides added to your code:
Hope this is something other people also want 🙂 I really wanted it, at least for Emacs 😛