Skip to content

Add theme "gui" for MacVim and Powerline font. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exdeniz
Copy link

@exdeniz exdeniz commented Oct 15, 2013

No description provided.

@fweep
Copy link
Owner

fweep commented Oct 17, 2013

Looking at the screenshot, it's not clear to me how this differs from the "fancy" theme. Does fancy not render properly for you? It doesn't look perfect with crappy fonts like Courier New, but the symbols appear to all be there.

Whatever glyphs you've used in your patch do not render nicely at all on my system, so I'm not inclined to merge this in. I don't want to get into adding too many choices for dividers either; I'm just looking for a base set that looks good for most people, and that depends a lot on your chosen font.

I'll look into making the divider glyphs something users can override with a config variable.

@exdeniz
Copy link
Author

exdeniz commented Oct 17, 2013

Divider glyphs in "fancy" theme not correctly displayed in MacVim. This glyphs from Powerline fonts and they displayed correctly in all apps on OSX (MacVim, Terminal, etc) If you need, i do screenshot with 'fancy' theme on MacVim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants