Sync to main attrs repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First stab at implementing hashcode caching (#423) Currently all existing tests pass but no cache_hash tests have yet been added. * Existing hash tests now pass on cache_hash classes * Add towncrier change log * Add documentation for cache_hash * Fixes bug with check that init=True if cache_hash=True * Fix long lines * Fix documentation issues * Add test for cache_hash requiring init * Improve test coverage * Remove now unnecessary 'pass' * Add periods to the end of exception strings * Add test docstrings for cache_hash tests * Clarify documentation of cache_hash * Recommend that hashable classes be frozen * Fix test references for exception messages
* Allow attributes to be called property and itemgetter * Add newsfragment
* Add weakref parameter to attr.s() #325 * Add weakref to simple_classes() strategy * Rename changelog file with actual PR (420.change.rst) * Add test_weakref_does_not_add_a_field() * Add docstrings to new weakref tests * Add missing blank line * Correct weakref handling of __weakref__ attributes or an inherrited slot * Correct typos and terms * Rename to weakref_slot * Parametrize more tests against weakref_slot True/False to expose trouble * Check if __weakref__ has been inherited via a __dict__ * Correct copy/pasted comment * Change weakref_slot default to True * Tidy and correct weakref -> weakref_slot
* Allow to override class vars of super classes w/ annotations Fixes #427 * Add newsfragment
* Make _Nothing a singleton * Satisfy linter * Correct rst syntax
Thanks to ABCs, "base class" is more Python than "superclass" and the latter is also slightly confusing by alluding to "super" and/or being judgy.
- mention that attr.s() has to be updated by hand - encourage to tick boxes that do not apply
This removes errors in attrs library when using mypy setting: `disallow_any_generics = True` Fixes #441
This PR adds `python_requires` into `setup.py` to prevent `pip` from installing `attrs` in unsupported python versions. I know that currently `attrs` supports a wide range of python versions but I think that it's always good to have some sanity check =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
.pyi)..rstfiles is written using semantic newlines.versionadded,versionchanged, ordeprecateddirectives.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!