chore: enable pnpm shellEmulator #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with |
|
Alright, fixed it! The whole npm_config_ hack is deprecated anyway and logs a bunch of warnings since npm 11.2, so I figure this is right direction. |
This fixes `pnpm build` on Windows. Otherwise, the string escapes in the `build` script are misinterpreted. After enabling `shellEmulator`, husky needed to be moved off npm. I can't repro the issues noted with pnpm over npm in CONTRIBUTING.
Excellent, thanks for the PRs! |
|
🎉 This PR is included in version 52.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started investigating #1432, but quickly hit Windows incompatibilities.
This fixes
pnpm buildon Windows.Otherwise, the string escapes in the
buildscript are misinterpreted.After enabling
shellEmulator, husky needed to be moved off npm. I can't repro the issues noted with pnpm over npm in CONTRIBUTING.Also, gitdown doesn't work on Windows, this glob evals to windows backslashes when
globwants forward slashes; I have to usegit push --no-verify.