test(no-types): check that the fix for no-types preserves asterisks #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeggse
changed the title
|
I see this is not working even after the |
brettz9
force-pushed
the
no-fix-break-multiline
branch
from
f2cd7ab to
97b1b5e
Compare
brettz9
added a commit
to skeggse/eslint-plugin-jsdoc
that referenced
this pull request
May 2, 2020
fix: remove last line break in last tag description for proper stringification (and fix old tests)
|
Btw, I've filed syavorsky/comment-parser#78 which should fix the underlying issue, and then once it may be merged, I've added a commit to your PR which should get things fixed on our end as well. |
brettz9
added a commit
to skeggse/eslint-plugin-jsdoc
that referenced
this pull request
May 3, 2020
fix: remove last line break in last tag description for proper stringification (and fix old tests) Impacts `check-param-names`, `check-property-names`, `empty-tags`, `no-defaults`, `no-types`, `require-example`, `require-param`, `require-property`
brettz9
force-pushed
the
no-fix-break-multiline
branch
from
97b1b5e to
0d930ea
Compare
Currently, the fix for `no-types` results in the removal of some asterisks from multiline descriptions. This makes eslint-plugin-jsdoc somewhat jarring to adopt.
brettz9
force-pushed
the
no-fix-break-multiline
branch
2 times, most recently
from
9ae1c34 to
ad5e376
Compare
…eak in last tag description for proper stringification (and fix old tests) Impacts `check-param-names`, `check-property-names`, `empty-tags`, `no-defaults`, `no-types`, `require-example`, `require-param`, `require-property`. Also updating other devDeps.
brettz9
force-pushed
the
no-fix-break-multiline
branch
from
ad5e376 to
5b6ebc2
Compare
|
🎉 This PR is included in version 24.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
If you already updated, please update further to 24.0.6 as it includes some fixes for a regression introduced in 24.0.3 (on which this merged PR built). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the fix for
no-typesresults in the removal of some asterisks from multiline descriptions. This makeseslint-plugin-jsdocsomewhat jarring to adopt.The proper fix here probably requires syavorsky/comment-parser#74.