-
-
Notifications
You must be signed in to change notification settings - Fork 163
no-multi-asterisks
rule
#730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think "ban multiple asterisks at line start" should be a special case of "require one space after asterisk". /**
** @param a // require one space after asterisk
*@param b // require one space after asterisk
*/ |
Can you please clarify? |
Since the potential rule "require one space after leading asterisk" would included the functionality of this pr and do more, it looks like a better solution. |
Heuristically, what I want is to enforce the style of leading asterisks, instead of banning a particular occurrence of |
Enforce the style to what exactly? One space vs. what? No spaces and a fixed number of spaces? While I can see allowing the parser to accept it in other styles or bad form, do a lot of projects actually use anything more than a single space in a consistent way? The spec, TS, Closure, etc., all seem, as I can recall, to just use just the one style. |
Yes I mean the one style. |
So you mean ensure there is one space even if not multiple asterisks--but enforce no other style, right? |
I suggest taking a look at my edit of #199 (comment) to ensure it clarifies what you want. |
I think what you are asking for is pretty much the expectation of |
If it wasn't clear, I mean that that is how |
Ok |
Are you ok with my going ahead with this (and the other PRs), or do you need more time to review? |
bb5213f
to
4f2286c
Compare
4f2286c
to
a54079c
Compare
…ddle delimiters or at end of blocks
a54079c
to
584b76e
Compare
🎉 This PR is included in version 34.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feat:
no-multi-asterisks
rule to prevent multiple asterisks with middle delimiters or at end of blocksFixes #199 (other fixes have now been merged).