Skip to content

Support webpack 4 and plugin maintenance / dev fixes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2018

Conversation

chrisblossom
Copy link
Contributor

This PR:

  • Adds support for Webpack 4, while preserving support for the old plugin system.
  • Moves over to the recommendedbabel-preset-env and requires node 4+ (might want to require node 6 lts+ as node 4 is no longer support starting the end of this month).
  • Upgrades packages to latest versions and fixes all lint issues.
  • Fixes sandbox (was not previously working) and upgrades sandbox config to be compatible with Webpack 4.

I verified Webpack 3 still works as expected.

Closes #50, #32, #52.

I know it isn't normal to have one PR with so many changes, but I was running into several things that was stopping development. For instance, there was a bug with Eslint v3 that was causing a lint error saying type UserOptionsType = { was not defined. Also, the sandbox config did not work at all.

If you want this PR split out into separate ones, or want something changed or removed, let me know.

@gajus gajus merged commit db382d0 into gajus:master Apr 20, 2018
@gajus
Copy link
Owner

gajus commented Apr 20, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support webpack@4
2 participants