-
Notifications
You must be signed in to change notification settings - Fork 126
Fix mcm_machine_set_failed_machines
metric to more accurately reflect current state
#1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…achine state in real time
takoverflow
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please update the release notes (you can check other PRs for reference)
aaronfern
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just a small nit
Co-authored-by: Aaron Francis Fernandes <[email protected]>
aaronfern
approved these changes
Aug 12, 2025
This was referenced Aug 29, 2025
This was referenced Aug 29, 2025
This was referenced Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/review
Needs review
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds changes such that a gauge metric scraped on prometheus gets cleared and re-populated on every poll, so that it reflects the latest state of the reference slice
*machineSet.Status.FailedMachines
.The logic to set this variable has also been updated so that it contains the current set of machines in the
Failed
state.Which issue(s) this PR fixes:
Fixes #476
Special notes for your reviewer:
IT for mcm-provider-aws passed
Testing was done by setting the
machineCreationTimeout
to a value lesser than the time it takes for a machine to be provisioned and move into theRunning
state (1m). The machine moves to theFailed
state, when it can be checked against a prometheus graph to verify if it was recorded accuratelySome changes were required to ensure a
Failed
machine stays failed, like an artificial delay in the goroutine marking a machine for deletionRelease note: