Changes in yarn api client for Enterprise gateway yarn checks. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…partition availability
|
@kevin-bates I have created this PR for the changes need in yarn api client for this PR:- |
kevin-bates
reviewed
Jul 24, 2019
There was a problem hiding this comment.
These changes look good to me and seem generally useful to others - thank you! I've left a few minor comments that might help users.
My other comment is we'll want to alter jupyter-server/enterprise_gateway#699 to tolerate None returned from cluster_scheduler_queue and cluster_queue_partition.
Closed
added 3 commits
July 25, 2019 11:09
|
@kevin-bates I have made the changes. |
|
I'd like to include this in 0.3.6 and will begin that process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following functions are added:-