Skip to content

fix: GetAllCasings.mjs - newline bug #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2022
Merged

fix: GetAllCasings.mjs - newline bug #1328

merged 2 commits into from
Mar 29, 2022

Conversation

pH-T
Copy link
Contributor

@pH-T pH-T commented Mar 28, 2022

@pH-T pH-T mentioned this pull request Mar 28, 2022
Merged
@n1474335 n1474335 merged commit 18022a2 into gchq:master Mar 29, 2022
@wesinator
Copy link
Contributor

Hi, two issues I'e noticed with this implementation:

  • name - calling it "casing" while the others are case make it harder to find - suggest renaming to "get all cases"?
  • there seems to be a bug in the iteration if the input string has commas, such as:
this is a test, test one, test two
this is a test, test one

The use case for this is getting the "normal" proper noun case on a separated list of names

This was referenced Jun 6, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pH-T @wesinator @n1474335