New IncDec plugin for Geany #1351

scresto09 · 2024-05-24T13:39:06Z

IncDec is a plugin for Geany that provides shortcuts to increment an decrement
number at the cursor, or to the right of the cursor (on the same line).

By default, typing Shift-+ will increment the next number, and typing Shift-- will decrement the next number.
You can also increment and decrement number many times by typing Shift-*. The number can be at the cursor, or to the right of the cursor (on the same line). Numbers can be negative and positive, and can be in decimal or hexadecimal format (hexadecimal number start with 0x).
You can customize those defaults keys on the preferences, under the Keybindings tab by setting the IncDec keybinding.
An item Increment or Decrement number is also added in the Editor Popup Menu, it can be hidden by changing the Plugins Preferences.

… decrement number at the cursor, or to the right of the cursor (on the same line). By default, typing Shift-+ will increment the next number, and typing Shift-- will decrement the next number. You can also increment and decrement number many times by typing Shift-*. The number can be at the cursor, or to the right of the cursor (on the same line). Numbers can be negative and positive, and can be in decimal or hexadecimal format (hexadecimal number start with 0x). You can customize those defaults keys on the preferences, under the Keybindings tab by setting the *IncDec* keybinding. An item *Increment or Decrement number* is also added in the Editor Popup Menu, it can be hidden by changing the Plugins Preferences.

scresto09 · 2024-05-24T13:40:07Z

This pull request replace previous #1337

eht16

Nice, thanks!

I added a few minor remarks.
Additionally, could you please update the MAINTAINERS file in the root directory?

Thanks.

configure.ac

incdec/src/incdec-plugin.c

eht16 · 2025-02-01T16:08:52Z

Thanks. I think it's ok to merge.

@scresto09 if you change the code the next time, I suggest to remove the mixed indentation (spaces and tabs). It's not utterly important but makes the code a bit nicer and easier to read.

scresto09 · 2025-02-04T08:18:33Z

OK, thanks !

scresto31 · 2025-07-07T10:34:36Z

Hi, any update on merging this plugin? Thanks

b4n · 2025-07-07T16:34:49Z

incdec/src/incdec-plugin.c

+#define HEXA_NONE               -1      /* hexadecimal number not found */
+#define HEXA_MAYBE              0       /* in progress, need scan more characters */
+#define HEXA_REQUIRE_x          1       /* need character x/X */
+#define HEXA_REQUIRE_0          2       /* need character 0 */
+#define HEXA_REQUIRE_xnumber    3       /* need at least one number */
+#define HEXA_ACCEPT_xnumber     4       /* there may be more numbers */
+#define HEXA_FOUND              5       /* ok, hexadecimal number found */


Sounds like good candidates for an enum

Something like this:

Suggested change

#define HEXA_NONE -1 /* hexadecimal number not found */

#define HEXA_MAYBE 0 /* in progress, need scan more characters */

#define HEXA_REQUIRE_x 1 /* need character x/X */

#define HEXA_REQUIRE_0 2 /* need character 0 */

#define HEXA_REQUIRE_xnumber 3 /* need at least one number */

#define HEXA_ACCEPT_xnumber 4 /* there may be more numbers */

#define HEXA_FOUND 5 /* ok, hexadecimal number found */

enum {

HEXA_NONE = -1, /* hexadecimal number not found */

HEXA_MAYBE, /* in progress, need scan more characters */

HEXA_REQUIRE_x, /* need character x/X */

HEXA_REQUIRE_0, /* need character 0 */

HEXA_REQUIRE_xnumber, /* need at least one number */

HEXA_ACCEPT_xnumber, /* there may be more numbers */

HEXA_FOUND /* ok, hexadecimal number found */

};

Just a suggestion though, current code isn't a problem

b4n · 2025-07-07T16:35:26Z

incdec/src/incdec-plugin.c

+#define DECIMAL_NONE            -1      /* decimal number not found */
+#define DECIMAL_MAYBE           0       /* in progress, need scan more characters */
+#define DECIMAL_REQUIRE_number  1       /* need at least one number */
+#define DECIMAL_FOUND           5       /* ok, decimal number found */


Ditto (although less so)

b4n · 2025-07-07T16:35:33Z

incdec/src/incdec-plugin.c

+#define HEXA_CASE_UNKNOWN       -1      /* hexadicmal case not yey known */
+#define HEXA_CASE_UPPER         1       /* upper case detected */
+#define HEXA_CASE_LOWER         0       /* lower case detected */


b4n · 2025-07-07T16:42:01Z

incdec/src/incdec-plugin.c

+
+static gboolean on_change_number(gint step)
+{
+	ScintillaObject *sci = document_get_current()->editor->sci;


document_get_current() can return NULL, you need to guard this against that case. E.g. ~~I believe~~ you'll get a crash if you hit one of the keybindings when no document is open (which is a possibility).

Suggested change

ScintillaObject *sci = document_get_current()->editor->sci;

GeanyDocument *doc = document_get_current();

ScintillaObject *sci;

if (! doc)

{

return FALSE;

}

sci = doc->editor->sci;

incdec/src/incdec-plugin.c

b4n · 2025-07-07T19:49:04Z

incdec/src/incdec-plugin.c

+		if (use_hexa)
+		{
+			guessed_number = g_ascii_strtoll(txt, NULL, 16);
+		}
+		else
+		{
+			guessed_number = atoi(txt);
+		}


any reason not to do this?:

Suggested change

if (use_hexa)

{

guessed_number = g_ascii_strtoll(txt, NULL, 16);

}

else

{

guessed_number = atoi(txt);

}

guessed_number = g_ascii_strtoll(txt, NULL, use_hexa ? 16 : 10);

b4n · 2025-07-07T19:58:58Z

incdec/src/incdec-plugin.c

+
+	gint hexa_state = 0;
+	gint decimal_sate = 0;
+	gint hexaCase = HEXA_CASE_UNKNOWN;


Another one that probably should use snake_case hexa_case

b4n · 2025-07-07T20:29:55Z

incdec/src/incdec-plugin.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
+		g_snprintf(format_buf, sizeof(format_buf)-1, "%%0%d%c", format_length, use_hexa ? (hexaCase == HEXA_CASE_UPPER ? 'X' : 'x') : 'd');
+#pragma GCC diagnostic pop
+
+		if ((buf = g_strdup_printf(format_buf, guessed_number)))


Maybe do this:

Suggested change

#pragma GCC diagnostic push

#pragma GCC diagnostic ignored "-Wformat-nonliteral"

g_snprintf(format_buf, sizeof(format_buf)-1, "%%0%d%c", format_length, use_hexa ? (hexaCase == HEXA_CASE_UPPER ? 'X' : 'x') : 'd');

#pragma GCC diagnostic pop

if ((buf = g_strdup_printf(format_buf, guessed_number)))

if (use_hexa)

{

buf = g_strdup_printf(hexaCase == HEXA_CASE_UPPER

? "%0*" G_GINT64_MODIFIER "X"

: "%0*" G_GINT64_MODIFIER "x",

format_length, (guint64) guessed_number);

}

else

{

buf = g_strdup_printf("%0*" G_GINT64_FORMAT, format_length, guessed_number);

}

if (buf)

b4n · 2025-07-07T20:45:59Z

incdec/src/incdec-plugin.c

+
+		GtkWidget *content_area = gtk_dialog_get_content_area(GTK_DIALOG(plugin_data._dialog));
+
+		GtkWidget *label = gtk_label_new("Enter the number of positive or negative increments to apply.\n");


This string isn't marked as translatable. Also, no need for the \n at the end

Suggested change

GtkWidget *label = gtk_label_new("Enter the number of positive or negative increments to apply.\n");

GtkWidget *label = gtk_label_new(_("Enter the number of positive or negative increments to apply:"));

Also, you should make the entry as the "mnemonic widget" for this label somewhere below, which allows a semantic relation between the two, which in turn allows e.g. a screen reader to properly announce the widgets:

gtk_label_set_mnemonic_widget(GTK_LABEL(label), plugin_data._entry);

b4n · 2025-07-07T20:50:23Z

incdec/src/incdec-plugin.c

+
+		plugin_data._entry = gtk_spin_button_new_with_range(-64000, 64000,1);
+		gtk_spin_button_set_value(GTK_SPIN_BUTTON(plugin_data._entry), 1);
+		gtk_widget_set_tooltip_text(plugin_data._entry, _("Enter the number of positive or negative increments to apply then press Enter key.\n"));


Suggested change

gtk_widget_set_tooltip_text(plugin_data._entry, _("Enter the number of positive or negative increments to apply then press Enter key.\n"));

gtk_widget_set_tooltip_text(plugin_data._entry, _("Enter the number of positive or negative increments to apply then press Enter key."));

incdec: fix POTFILES.in

5889910

eht16 requested changes Jan 5, 2025

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

incdec/src/incdec-plugin.c Outdated Show resolved Hide resolved

incdec/src/incdec-plugin.c Outdated Show resolved Hide resolved

incdec/src/incdec-plugin.c Show resolved Hide resolved

eht16 reviewed Jan 5, 2025

View reviewed changes

incdec/src/incdec-plugin.c Outdated Show resolved Hide resolved

scresto09 added 2 commits January 24, 2025 11:33

Merge branch 'geany:master' into incdec-plugin-geany

abd29d3

incdec: Cosmetic changes in the code and key binding updates

e5dcca3

scresto09 requested a review from eht16 January 24, 2025 14:30

incdec: Cosmetic changes in the code

6f27cdd

eht16 approved these changes Feb 1, 2025

View reviewed changes

b4n added this to the 2.2.0 milestone Jul 7, 2025

b4n requested changes Jul 7, 2025

View reviewed changes

-	ScintillaObject *sci = document_get_current()->editor->sci;
+	GeanyDocument *doc = document_get_current();
+	ScintillaObject *sci;
+	if (! doc)
+	{
+		return FALSE;
+	}
+	 sci = doc->editor->sci;


		GtkWidget *content_area = gtk_dialog_get_content_area(GTK_DIALOG(plugin_data._dialog));

		GtkWidget *label = gtk_label_new("Enter the number of positive or negative increments to apply.\n");

	GtkWidget *label = gtk_label_new("Enter the number of positive or negative increments to apply.\n");
	GtkWidget *label = gtk_label_new(_("Enter the number of positive or negative increments to apply:"));

	gtk_widget_set_tooltip_text(plugin_data._entry, _("Enter the number of positive or negative increments to apply then press Enter key.\n"));
	gtk_widget_set_tooltip_text(plugin_data._entry, _("Enter the number of positive or negative increments to apply then press Enter key."));

New IncDec plugin for Geany #1351

Are you sure you want to change the base?

New IncDec plugin for Geany #1351

Uh oh!

Conversation

scresto09 commented May 24, 2024

Uh oh!

scresto09 commented May 24, 2024

Uh oh!

eht16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eht16 commented Feb 1, 2025

Uh oh!

scresto09 commented Feb 4, 2025

Uh oh!

scresto31 commented Jul 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants