Added macvlan network to allow for pi-hole DHCP #10
Conversation
|
See also: #8 |
|
I've been running this for a while now and it hasn't broken yet :) |
| # More info at https://github.com/pi-hole/docker-pi-hole/ and https://docs.pi-hole.net/ | ||
| services: | ||
| pihole: | ||
| container_name: pihole | ||
| image: pihole/pihole:latest | ||
| hostname: '{{ pihole_hostname }}' | ||
| networks: | ||
| pihole_network: | ||
| ipv4_address: '{{ pihole_ipaddr }}' |
There was a problem hiding this comment.
Where is pihole_ipaddr being defined?
There was a problem hiding this comment.
It's defined in the config.yml I'll add it to the example file but I feel like it might need more explanation, maybe in the readme?
tasks/pi-hole.yml
Outdated
|
|
||
| - name: CIDR subnet is | ||
| ansible.builtin.debug: | ||
| msg: 'Subnet: {{ mask_cidr }}' |
There was a problem hiding this comment.
Are these two debug tasks needed? Or were they just for testing/debug?
There was a problem hiding this comment.
The debug message isn't needed. I've removed that, however mask_cidr is used in the docker compose file
|
@geerlingguy, anything else required before merging ? |
|
I wanted to solve the same problem using a DHCP relay as described here, just for fun. The relay runs in an additional container, and is enabled/disabled from the config file. Let me know if you're interested in a pull request. |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
@dturaev, would be a nice addition. Let me know if you have it ready on your end. I've been wanting to implement it for long. |
|
This issue is no longer marked for closure. |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
Because DHCP is dependent on network broadcasts, the default bridged network won't work.
The easiest method would probably just be to set the network mode to host, but then we risk running into port conflicts.
because of this, and because the pi-hole server needs a static IP if it is to act as DHCP server, I decided to instead go for the
macvlannetwork driver, which gives the pi-hole container a static IP on the same network as the pi.I'd like some feedback on how to handle this.
As it stands you need
pip install netaddron the ansible controller, as I have the pi-hole task calculate the CIDR mask from the netmask. That could alternatively be provided by the user in the config?Maybe it should also be optional, and just let people run the default bridged mode if they don't intend to use the DHCP functionality?