Adopt lucuma-typed #351
Merged
Adopt lucuma-typed #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddburnside
approved these changes
Feb 7, 2023
| @@ -31,6 +31,10 @@ case class AccordionMultiple( | |||
| def withMods(mods: TagMod*) = addModifiers(mods) | |||
|
|
|||
| override val rawActiveIndex = activeIndices.map(_.map(_.toDouble).toJSArray) | |||
| override val rawOnTabChange = | |||
| onTabChange.map( | |||
| _.compose[Double | js.Array[Double]](_.asInstanceOf[js.Array[Int]].toList) | |||
There was a problem hiding this comment.
Did I know you could just asInstanceOf an Array[Double] to an Array[Int]? If not, I should remember it.
| @@ -48,7 +48,7 @@ object RadioButton { | |||
| .applyOrNot(props.tooltipOptions, (c, p) => c.tooltipOptions(p.asInstanceOf[CTooltipOptions])) | |||
| .applyOrNot( | |||
| props.onChange, | |||
| (c, p) => c.onChange(scp => p(props.valueFinder(scp.value), scp.checked)) | |||
| (c, p) => c.onChange(scp => p(props.valueFinder(scp.value), scp.checked.getOrElse(false))) | |||
There was a problem hiding this comment.
Wow. They seem to have suddenly decided that a lot of things are optional. :(
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the ST generation to the new lucuma-typed repo.
https://github.com/gemini-hlsw/lucuma-typed
The advantage of this is that the facades are now effectively cached artifacts, so working in this repo should be more pleasant. Also, they now share common facades (e.g. std, react), instead of re-generating them for each "leaf" in the dependency tree.
Unfortunately I got entangled in some ST/JS facade updates in this PR, so the diff is a lot...