Skip to content

Import semantic-ui #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Import semantic-ui #7

wants to merge 9 commits into from

Conversation

armanbilge
Copy link
Collaborator

Resuscitates #6.

@armanbilge
Copy link
Collaborator Author

So, the situation with js.| which becomes a true union type in Scala 3 is really really bad for some reason.

For example this code

as.toJs.foreach(v => p.as = v)
                     ~~~~~~~~
Found:    (v : Object)
Required: scala.scalajs.js.UndefOr[react.semanticui.AsT]

But, if I explicitly annotate (v: js.UndefOr[AsT]) => ... then it compiles.

@armanbilge armanbilge mentioned this pull request Mar 25, 2022
Closed
3 tasks
@armanbilge
Copy link
Collaborator Author

Waiting to see what happens in:

@armanbilge armanbilge closed this Jun 17, 2022
@armanbilge armanbilge deleted the topic/semantic-ui branch June 17, 2022 23:11
@armanbilge armanbilge mentioned this pull request Jun 17, 2022
@armanbilge armanbilge restored the topic/semantic-ui branch June 18, 2022 03:01
@armanbilge armanbilge deleted the topic/semantic-ui branch June 18, 2022 04:17
@armanbilge armanbilge restored the topic/semantic-ui branch June 24, 2022 22:22
@armanbilge armanbilge deleted the topic/semantic-ui branch June 26, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant