feat: contains fn #1235
Merged
feat: contains fn #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Jul 15, 2025
rust/geoarrow-geo/src/contains.rs
Outdated
Comment on lines
7
to
10
| pub fn contains<'a>( | ||
| left_array: &'a impl GeoArrowArrayAccessor<'a>, | ||
| right_array: &'a impl GeoArrowArrayAccessor<'a>, | ||
| ) -> GeoArrowResult<BooleanArray> { |
There was a problem hiding this comment.
Similarly to intersects, we want the public API to be in terms of &dyn GeoArrowArray, not GeoArrowArrayAccessor. The latter would require all users to manually downcast their data to a concrete type, which we don't want to require them to do.
Follow the layout of intersects which has a separate inner function that takes in GeoArrowArrayAccessor
rust/geoarrow-geo/src/contains.rs
Outdated
Comment on lines
11
to
15
| assert_eq!( | ||
| left_array.len(), | ||
| right_array.len(), | ||
| "Arrays must have the same length" | ||
| ); |
There was a problem hiding this comment.
Similarly to intersects we want this to return an error, not panic.
kylebarron
approved these changes
Jul 16, 2025
rust/geoarrow-geo/src/contains.rs
Outdated
| let result = left_geom.contains(&right_geom); | ||
| builder.append_value(result); | ||
| } | ||
| (None, _) | (_, None) => { |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1205 , Follows #1207 example for DE-9IM predicates and added
contains. Used geo'scontainmethod.Tests right now are right polygon contained in left, two polygons that don't contain one another, and mixed geometry of line and point being contained in line.
Please let me know if more tests should be added.