Feature/core 8922 dropdown issue end of screen #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2022 01:57
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dletran
reviewed
Dec 22, 2022
| const fitsBelow = popupRect.height < availableHeightBelow | ||
| const fitsAbove = popupRect.height < availableHeightAbove | ||
| if (fitsAbove && (containerRect.top + availableHeightAbove > viewport.height)) { |
There was a problem hiding this comment.
what does this condition mean? let's try to include the second part (containerRect.top + availableHeightAbove > viewport.height) in a constant so it's easier to read
There was a problem hiding this comment.
should we make this check for the 4 sides? top, bottom, left and right?
There was a problem hiding this comment.
yes i think i need to add for bottom side as well. this is a condition that if the popup is higher then the container and excessing the end of screen, it detects and making the popup smaller and handles the translation
There was a problem hiding this comment.
- include second part in the constant
- check it for 4 sides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.