Skip to content

Issue with syntax highlighter in a version controled directory #214

Closed
@vinhphamuit

Description

@vinhphamuit

Hello, I found some issues with syntax highlighter in a version controled directory with Geometry theme.

When you type something in a version controled directory with syntax highlighter is on, and then move the cursor back to the part where there is the command is highlighted, it would show something like this.
image

This issue doesn't happen with the deafult theme nor in the normal directory.
It's kinda annoying when you mistype something and want to fix but can't see anything. It would be very nice if it's fixed.

Activity

jedahan

jedahan commented on Jun 9, 2018

@jedahan
Member

Which syntax highlighter are you using? I am having trouble reproducing this issue on maxOS 10.14.3 in iTerm2 and Alacritty, using https://github.com/zsh-users/zsh-autosuggestions.

Can you share the most minimal zshrc that can reproduce this issue?

vinhphamuit

vinhphamuit commented on Jun 10, 2018

@vinhphamuit
Author
jedahan

jedahan commented on Jun 10, 2018

@jedahan
Member

Can you try these two things?

  1. Update the prezto syntax-highlighting submodule to the latest version
  2. Try using https://github.com/zdharma/fast-syntax-highlighting ?

I want to try and find where the conflict is.

vinhphamuit

vinhphamuit commented on Jun 10, 2018

@vinhphamuit
Author
  1. Update prezto syntax-highlighting submodule to the latest version doen't help.
  2. Using fast-syntax-highlighting does help and doen't the same issue like above :)
jedahan

jedahan commented on Jun 10, 2018

@jedahan
Member

Are you happy using zdharma/fast-syntax-highlighting ? Maybe we can open an issue on zsh-users/zsh-synax-highlighting and see if we can fix things there? Maybe it relates to zsh-users/zsh-syntax-highlighting#470 or zsh-users/zsh-syntax-highlighting#160 ...

vinhphamuit

vinhphamuit commented on Jun 10, 2018

@vinhphamuit
Author

Maybe I will use fast-syntax-highlighting for a while.

frm

frm commented on Jun 27, 2018

@frm
Member

@jedahan any idea what this might be?

jedahan

jedahan commented on Jun 27, 2018

@jedahan
Member

@fribmendes when I looked around a while ago, it just seemed something underlying with zsh-syntax-highlighting being a bit buggy, and since fast-syntax-highlighting is nicer I just use that. I am trying to reduce my responsibilities a bit so since there is a working alternative I am happy to close this and recommend people use fast-syntax-highlighting. It's also a bit painful with people coming from frameworks that are harder to integrate with outside sources like ours. If someone who maintains omz or prezto includes geometry i'm happy to help work with them a bit, but this seems a hairy corner of ZLE that I have trouble debugging.

frm

frm commented on Jun 28, 2018

@frm
Member

I am happy to close this and recommend people use fast-syntax-highlighting

Yep, I'm perfectly fine with this. I can add it to the FAQ, in case this comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jedahan@frm@vinhphamuit

        Issue actions

          Issue with syntax highlighter in a version controled directory · Issue #214 · geometry-zsh/geometry