Add import on completion #167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgewfraser Any update on if this can be added? I am unable to get auto-import/complete working even on save/format with a Bazel project. |
|
Hey sorry for slow review. I'm supportive of this change, and I think it would be better to put "reorganize imports" behind a code-action once this is in. But I think this isn't quite the right way to do it, it crosses a lot of weird boundaries in how the methods are organized. |
|
Hi @georgewfraser, I think that in the next few weeks i'll be able to make a proper implementation, I'm closing this PR. |
|
I tested this and just works. Has the benefit to use the selected class from dropdown so import will be correct in case of ambiguity. @georgewfraser any suggestion on how to refactor this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idk if this is the best way to do it, but it works
fixes #96