Fix hierarchy cleanup error when using type_caster #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where a database proxy tries to access the type_caster on the aliased arel table. Since this is just an alias table of the current model, it makes sense to use the current model's type_caster for the alias.
|
This didn't include tests as the tests that came to mind were a bit heavy for what already exists in the code. I'm open to suggestions if tests are needed. |
jmarianer
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where a database proxy tries
to access the type_caster on the aliased arel table. Since
this is just an alias table of the current model, it makes
sense to use the current model's type_caster for the alias.