assert that offset is an integer #26

ldanilek · 2025-03-06T16:21:55Z

users in discord are reporting errors that look like

offset exceeded count by -3.9999999999990905

which could be from two root causes:

btree nodes are somehow getting counts that are not integers. i checked the float64 spec (and asked chatgpt deep research) and I don't see how this could happen, since all we do is start with 0 or 1 and do addition or subtraction.
the input offset is not a precise integer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sujayakar · 2025-03-06T22:47:45Z

src/component/btree.ts

+  if (args.offset !== Math.floor(args.offset)) {
+    throw new Error("offset must be an integer");
+  }


you can use Number.isInteger

assert that offset is an integer

abdd72e

ldanilek requested a review from sujayakar March 6, 2025 16:21

sujayakar reviewed Mar 6, 2025

View reviewed changes

ldanilek requested a review from sujayakar March 7, 2025 19:23

.

f9b662e

sujayakar approved these changes Mar 8, 2025

View reviewed changes

Provide feedback