Export QueryStream #712
Merged
Export QueryStream #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmacartney
approved these changes
Aug 1, 2025
commit: |
|
you can test that it fixes it with the pkg-pr-new version above. If that's all good I'll put it out in the next release |
Just tested it, works great! Thanks a lot 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating Effect wrappers around Convex and ConvexHelpers, and while working on the stream helpers, I struggled a lot with TypeScript because I don't have access to the type of the internal
QueryStreamclass. If it's ok to export it that would help me avoid having to do castings toany😅.(If not, that's fine)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.