Custom port option for database connection #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbisso Thanks very much for submitting this. I must confess I missed the notification. I will review and attempt to merge asap. Could you please amend the pull request to go into "develop" branch as well please? |
|
No problem - thanks for the good work. I'm not sure how to amend the PR destination so I've created a separate one for the develop branch. Feel free to close this one if needed. |
|
Ok closing this one in favour of one that is going into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use MAMP for local development which runs MySQL on port
8889rather than the standard3306. This PR adds the option to specify a custom port for the database connection. Hopefully it will help others in a similar situation.