HTTP-150 Add Proxy to HttpClient for Lookup Source #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz8
reviewed
May 22, 2025
src/main/java/com/getindata/connectors/http/internal/utils/JavaNetHttpClientFactory.java
Outdated
Show resolved
Hide resolved
grzegorz8
changed the title
grzegorz8
reviewed
May 22, 2025
grzegorz8
reviewed
May 23, 2025
| this.authenticator = Optional.of(new Authenticator() { | ||
| @Override | ||
| protected PasswordAuthentication getPasswordAuthentication() { | ||
| return new PasswordAuthentication(proxyUsername.get(), proxyPassword.get().toCharArray()); |
There was a problem hiding this comment.
I guess we can return custom PasswordAuthentication only if the proxy is the requestor:
if (getRequestorType().equals(RequestorType.PROXY) && getRequestingHost().equalsIgnoreCase(host)) {
return new PasswordAuthentication(proxyUsername.get(),
proxyPassword.get().toCharArray());
} else {
return null;
}There was a problem hiding this comment.
Thanks for the input, done!
src/main/java/com/getindata/connectors/http/internal/utils/ProxyConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/getindata/connectors/http/internal/utils/ProxyConfig.java
Outdated
Show resolved
Hide resolved
- PasswordAuthentication only if the proxy is the requestor
grzegorz8
approved these changes
May 23, 2025
davidradl
pushed a commit
to davidradl/flink-http-connector
that referenced
this pull request
Sep 11, 2025
davidradl
pushed a commit
to davidradl/flink-http-connector
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have the issue that we cannot query an API from within our Kubernetes cluster due to some security concerns. This PR adds an optional parameter "proxy" that facilitates the usage of a proxy in the HttpClient for the lookup source.
Resolves
150PR Checklist