Skip to content

Conversation

davidradl
Copy link
Collaborator

Description

add path patameter support

Resolves #74

PR Checklist

@davidradl davidradl marked this pull request as ready for review March 29, 2024 17:46
@davidradl
Copy link
Collaborator Author

davidradl commented Mar 29, 2024

@OlivierZembri @AdrianVasiliu please could you review and see if this would meet your needs?

Copy link
Contributor

@AdrianVasiliu AdrianVasiliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely does the trick, thanks David.

I think it would be worth adding an entry for it under https://github.com/getindata/flink-http-connector/blob/c2f3e7bdc6b9d03bf3b807ac30a1302f026f82dc/CHANGELOG.md#unreleased.

@davidradl davidradl force-pushed the flink74 branch 2 times, most recently from 0f982d0 to e9b3e2c Compare April 2, 2024 10:21
Copy link
Contributor

@AdrianVasiliu AdrianVasiliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition to the changelog. From my chair, approving.

@davidradl
Copy link
Collaborator Author

@kristoffSC the submitters of this issue have approved this change, are you ok to merge please?

@grzegorz8 grzegorz8 changed the title http74 add path parameter support HTTP-74 add path parameter support Apr 3, 2024
@grzegorz8 grzegorz8 changed the title HTTP-74 add path parameter support HTTP-74 Add path parameter support Apr 3, 2024
@davidradl davidradl closed this Apr 3, 2024
@davidradl
Copy link
Collaborator Author

davidradl commented Apr 3, 2024

@grzegorz8 I accidentally closed this - it is reopened with the changes you requested.

@davidradl davidradl reopened this Apr 3, 2024
@grzegorz8 grzegorz8 merged commit 93b0358 into getindata:main Apr 3, 2024
OlivierZembri pushed a commit to OlivierZembri/flink-http-connector that referenced this pull request Apr 3, 2024
OlivierZembri pushed a commit to OlivierZembri/flink-http-connector that referenced this pull request Apr 3, 2024
PeatBoy pushed a commit to hyperpaas/flink-http-connector that referenced this pull request Jan 21, 2025
davidradl added a commit to davidradl/flink-http-connector that referenced this pull request Sep 11, 2025
davidradl added a commit to davidradl/flink-http-connector that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for API path parameters
4 participants